-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Structure Design Page (Lab Notebook) #50
Conversation
IcedTea2K
commented
Oct 24, 2023
- Page is too long, so video is too big to upload
- References are not complete, but it should be merged for now. We can fix them again on Thursday, when reviewing with the write-up team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, equations were definitely worth your pain and suffering
Only general nitpick I have is the spacing for images/graphics, make sure there's a proper amount of whitespace so it looks nice. I also changed the CaptionedGraphics
component in another branch already to have smaller caption font size so it's easier to differentiate from the actual content text.
</p> | ||
|
||
<section class="py-2" v-for="(structure, i) in structures"> | ||
<h3 class="text-base text-white"> {{ structure.label }} </h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use sectionStyle for the styling here just for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha gotcha
values : [1.090856, 2.946035, 2.508811] | ||
}, | ||
{ | ||
label: "Structure: 3-gon", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they want you to specify "x-gonal Bipyramid" like in the doc or is just "x-gon" fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I added the content it was only x-gon, I think. I'll fix it 🖖
This consistent approach enables a more structured comparison across various DNA structures. Our observations indicate that, for the most part, these structures maintain a similar level of stability. Our reference structure, which serves as a benchmark, displays certain interconnected segments. This interconnectedness is also evident, albeit to a reduced degree, in another structure called the 5-gon. | ||
A point of interest across these structures is the presence of a segment or edge that isn't as stable as the others. This unstable segment could be a pivotal factor in understanding why some DNA structures have the ability to connect or polymerize. Research by Lin et. al supports this notion, demonstrating that specific DNA structures can link together, forming chains that are illustrated in their provided figure (Figure X). | ||
</p> | ||
<CaptionedGraphics> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably throw in a caption specifying that this is Figure X
</section> | ||
|
||
<section> | ||
<h3 :class="sectionStyle"> Axial Edge </h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to "Diameter to Number of Nucleotides"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done boss
\end{align*}" :display-mode="true"/> | ||
</div> | ||
<p> | ||
for integer solutions of <Equation formula="a, b"/> to exist. It should be noted that, given <Equation formula="a \in \mathbb{Z}"/>, <Equation formula="N/n \equiv a\text{ mod }2 \Longrightarrow n | N"/>. However, <Equation formula="n|N"/>, while the parity equation developed above is less complicated to employ since only tiny adjustments to <Equation formula="a,b"/> would be necessary to obtain the closest even or odd number that satisfies the condition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "is a difficult criteria to satisfy, " between the second n|N
and while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright boss
✅ Deploy Preview for biomod2023 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed some formatting for better spacings + responsiveness; merge if everything looks good
Side note - you can't put other block-level elements like ol in a p tag - ex. anything that's not a span, b, i, etc. |